Skip to content

rev package:pool in prep for publishing#2166

Merged
devoncarew merged 1 commit intodart-lang:mainfrom
devoncarew:publish_pool
Sep 17, 2025
Merged

rev package:pool in prep for publishing#2166
devoncarew merged 1 commit intodart-lang:mainfrom
devoncarew:publish_pool

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Sep 16, 2025

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from a team as a code owner September 16, 2025 18:53
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the pool package for publishing by updating its version from 1.5.2-wip to 1.5.2 in both CHANGELOG.md and pubspec.yaml. The changes are straightforward and correctly align with the goal of releasing a new package version. The update is consistent across the modified files, and I see no issues with this change.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:bazel_worker 1.1.3 already published at pub.dev
package:benchmark_harness 2.4.0-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.5.0-wip WIP (no publish necessary)
package:clock 1.1.3-wip WIP (no publish necessary)
package:code_builder 4.11.0 already published at pub.dev
package:coverage 1.15.0 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.6 already published at pub.dev
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 4.0.0 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:package_config 2.3.0-wip WIP (no publish necessary)
package:pool 1.5.2 ready to publish pool-v1.5.2
package:process 5.0.5 already published at pub.dev
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.5.0 already published at pub.dev
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.8 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.3.0 already published at pub.dev
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 8.0.5 already published at pub.dev
package:watcher 1.1.3 already published at pub.dev
package:yaml 3.1.3 already published at pub.dev
package:yaml_edit 2.2.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
pool Breaking 1.5.1 1.5.2 2.0.0
Got "1.5.2" expected >= "2.0.0" (breaking changes)		 ⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@devoncarew devoncarew merged commit 042b03e into dart-lang:main Sep 17, 2025
14 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 18, 2025
@devoncarew
[deps] rev ai, dartdoc, http, protobuf, tools
52e2c13 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/bc90433..078abd2):
  078abd2  2025-09-16  Greg Spencer  Remove a reference to screenshots for generic error (dart-lang/ai#280)

dartdoc (https://github.com/dart-lang/dartdoc/compare/49fc272..4df6dbe):
  4df6dbe5  2025-09-18  Sarah Zakarias  Undo deprecation of api exports (dart-lang/dartdoc#4105)

http (https://github.com/dart-lang/http/compare/ef05b37..d8e6929):
  d8e6929  2025-09-18  Brian Quinlan  Only set the charset when the body is set for certain mime types (dart-lang/http#1798)

protobuf (https://github.com/dart-lang/protobuf/compare/971bcae..456e2ee):
  456e2ee  2025-09-16  Ömer Sinan Ağacan  Generate unittest_features proto (google/protobuf.dart#1051)
  c215029  2025-09-16  Ömer Sinan Ağacan  Update pre-generated protos (google/protobuf.dart#1050)

tools (https://github.com/dart-lang/tools/compare/4254267..042b03e):
  042b03e8  2025-09-17  Devon Carew  rev package:pool in prep for publishing (dart-lang/tools#2166)

Change-Id: I14a1b43be92702489925dd7968853ef043d42bfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Dhruv-Maradiya pushed a commit to Dhruv-Maradiya/tools that referenced this pull request Oct 15, 2025
@devoncarew @Dhruv-Maradiya
rev package:pool in prep for publishing (dart-lang#2166)
c345401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosuem mosuem mosuem approved these changes

@natebosch natebosch Awaiting requested review from natebosch

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package:pool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update pool package in pub.dev

2 participants

@devoncarew @mosuem